Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in EC2 credential provider parsing #315

Merged
merged 1 commit into from
Jun 24, 2014

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Jun 23, 2014

The only parser basically had::

config = dict(line.split('=', 1) for line in lines if '=' in line)

access_key = config.get('AWSAccessKeyId')
secret_key = config.get('AWSSecretKey')

Which ignores lines that don't have a '=' char in it. This behavior has been
re-added and additional tests to cover a few of these edge cases have also
been added.

cc @danielgtaylor

The only parser basically had::

    config = dict(line.split('=', 1) for line in lines if '=' in line)
    access_key = config.get('AWSAccessKeyId')
    secret_key = config.get('AWSSecretKey')

Which ignores lines that don't have a '=' char in it.
This behavior has been re-added and additional tests to cover a few of
these edge cases have also been added.
@danielgtaylor
Copy link
Member

LGTM 🚢-it!

@jamesls jamesls merged commit b2a0b32 into boto:develop Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants