Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where X-Amz-Content-SHA256 was being set twice #388

Merged
merged 3 commits into from
Nov 24, 2014
Merged

Fix issue where X-Amz-Content-SHA256 was being set twice #388

merged 3 commits into from
Nov 24, 2014

Commits on Nov 24, 2014

  1. Fix issue where X-Amz-Content-SHA256 was being set twice 

    More fallout from the fact that we resign requests.  There
was this Content-SHA256 header that did not have the "delete if
already present" logic, which would cause errors when retrying
S3 sigv4 requests because we would not be signing the requests
properly.

I've added a unittest as well as an integration test to ensure
we don't regress on this in the future.
    @jamesls
    jamesls committed Nov 24, 2014
    Configuration menu
    Copy the full SHA
    dbcbc39 View commit details
    Browse the repository at this point in the history

  2. Fix py3 test issue

    @jamesls
    jamesls committed Nov 24, 2014
    Configuration menu
    Copy the full SHA
    6e2692e View commit details
    Browse the repository at this point in the history

  3. Fix flake8 issues

    @jamesls
    jamesls committed Nov 24, 2014
    Configuration menu
    Copy the full SHA
    f8e7ae7 View commit details
    Browse the repository at this point in the history