Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set the Date header to the current date #399

Merged
merged 3 commits into from
Dec 5, 2014

Commits on Dec 4, 2014

  1. Always set the Date header to the current date

    This fixes a bug where if you resend a request and resign
    it without changing the date, you can get an auth error
    that your signature is too old if the retry loops fall outside
    the auth window (~15 minutes).
    
    What was happening is that we were trying a failed S3 request,
    but because we weren't re-setting the Date header, eventually
    the retried request would have a signature that was too old.
    jamesls committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    cfedf1b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2014

  1. Always set the sigv4 date to the current time

    Part of the reason this change looks more complicated than
    you would expect is because we use the sigv4 test suite
    (http://docs.aws.amazon.com/general/latest/gr/signature-v4-test-suite.html)
    to test our implementation.  However, these tests use a Date header
    whereas previous versions used an X-Amz-Date.
    
    We can possibly investigate always using Date instead of X-Amz-Date,
    but we'd need to make sure we aren't introducing any regressions.
    jamesls committed Dec 5, 2014
    Configuration menu
    Copy the full SHA
    c1e7c29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    319e7b4 View commit details
    Browse the repository at this point in the history