Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope sign request to service name #560

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Scope sign request to service name #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions botocore/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,9 @@ def __init__(self, serializer, endpoint, response_parser,
self.meta = ClientMeta(event_emitter, self._client_config,
endpoint.host, service_model,
self._PY_TO_OP_NAME)

# Register request signing, but only if we have an event
# emitter. When a client is cloned this is ignored, because
# the client's ``meta`` will be copied anyway.
if self.meta.events:
self.meta.events.register('request-created', self._sign_request)
self.meta.events.register('request-created.%s' %
service_model.service_name,
self._sign_request)

@property
def _service_model(self):
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,8 @@ def test_client_registers_request_created_handler(self):
creator = self.create_client_creator(event_emitter=event_emitter)
creator.create_client(
'myservice', 'us-west-2', credentials=self.credentials)
event_emitter.register.assert_called_with('request-created', mock.ANY)
event_emitter.register.assert_called_with('request-created.myservice',
mock.ANY)

def test_client_makes_call(self):
creator = self.create_client_creator()
Expand Down