Autopopulate CopySourceSSECustomerKeyMD5 for s3 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
added
the
pr/needs-review
|
Looks good to me 🚢 |
| return (params.get('SSECustomerKey') is not None and | ||
| 'SSECustomerKeyMD5' not in params) | ||
| def _needs_s3_sse_customization(params, sse_member_prefix='SSECustomer'): | ||
| return (params.get(sse_member_prefix+'Key') is not None and |
There was a problem hiding this comment.
I think we typically include spaces between operators
There was a problem hiding this comment.
hmm flake8 did not catch that. I am changing it, but for future references, there are some nuances to that rule in pep8 if you have multiple operators on the same line: https://www.python.org/dev/peps/pep-0008/#other-recommendations.
|
🚢 |
| def _needs_s3_sse_customization(params): | ||
| return (params.get('SSECustomerKey') is not None and | ||
| 'SSECustomerKeyMD5' not in params) | ||
| def _needs_s3_sse_customization(params, sse_member_prefix='SSECustomer'): |
There was a problem hiding this comment.
Any reason this needs to have a default value if we're always providing it when we call _needs_s3_sse_customization?
There was a problem hiding this comment.
Nah we do not need a default. Just forgot to remove it upon implementation.
|
@jamesls I updated. Let me know what you think. |
|
|
kyleknap
added a commit
that referenced
this pull request
Nov 4, 2015
Autopopulate CopySourceSSECustomerKeyMD5 for s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementing logic used for this PR: aws/aws-cli#1487. We have it for SSECustomer members but not the copy source one which may be needed when calling CopyObject.
cc @jamesls @mtdowling @rayluo @JordonPhillips