Verify MD5 is available #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, such as a FIPS enabled system, MD5 hashing is unavailable. This commit will detect when that is the case, avoiding it where possible and raising a better error otherwise.
| have access to it for various reasons, such as FIPS mode being enabled. | ||
| :return: True if md5 is available. False if not. | ||
| """ | ||
| try: |
There was a problem hiding this comment.
I don't think we need to check this each time. It's either available on the system or not. I'd prefer to just move this to a constant in this module.
JordonPhillips
force-pushed
the
check-md5
branch
from
165abea
to
eca32b4
Compare
JordonPhillips
added
pr/needs-review
| MD5_AVAILABLE = False | ||
|
|
||
|
|
||
| def get_md5(raise_error_if_unavailable=True, *args, **kwargs): |
There was a problem hiding this comment.
After discussing, we can remove the raise_error_if_unavailable argument implemented for the CLI and update the CLI code to not compute MD5's if it's not possible.
|
Looks good, just had that small comment about removing |
|
|
JordonPhillips
added a commit
that referenced
this pull request
Feb 25, 2016
Verify MD5 is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, such as a FIPS enabled system, MD5 hashing is unavailable. This commit will detect when that is the case, avoiding it where possible and raising a better error otherwise.
cc @jamesls @rayluo @kyleknap