Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transfers all of the boto3 s3 transfer logic to this library. So most of the code has been reviewed already. It also setup the automated testing for this repo through travis and the usual scripts that we use. Here are the things that you may want to look more closely at:
legacy
to represent that this code eventually will become legacy code as its existence is present because it is used in boto3 and may disappear as the library progresses. I also did this so that I would not have to touch any of that code when I start doing the major refactoring. I also considered putting the code in the__init__.py
file, but I did not do that because I do not want that code to be in there for the long run and want to reserve it for higher level stuff like aliasing major classes/functions and having the library version.botocore 1.3.0>=,<2.0.0
. It would have been difficult for me to remove it completely so I made sure the dependency range is pretty wide.requirements.txt
andrequirements26.txt
, I made onerequirements-test.txt
as I feel thatpip install -r
solely should only be used for testing.Let me know if there is anything else you see.
cc @jamesls @mtdowling @rayluo @JordonPhillips