-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summarize improvements #323
Open
aemous
wants to merge
3
commits into
boto:develop
Choose a base branch
from
aemous:summarize-improvements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
reviewed
Jan 7, 2025
Comment on lines
+36
to
+48
+------------------------+---------------------+---------------------+-----------+----------------------+ | ||
| Metric over 2 run(s) | Run 1 | Run 2 | Mean | Standard Deviation | | ||
+========================+=====================+=====================+===========+======================+ | ||
| Total Time (seconds) | 263.8085448741913 | 198.05210328102112 | 230.930 | 32.87822079658508 | | ||
+------------------------+---------------------+---------------------+-----------+----------------------+ | ||
| Maximum Memory | 117.9 MiB | 112.4 MiB | 115.2 MiB | 2.7 MiB | | ||
+------------------------+---------------------+---------------------+-----------+----------------------+ | ||
| Maximum CPU (percent) | 0.2 | 0.2 | 0.2 | 0.0 | | ||
+------------------------+---------------------+---------------------+-----------+----------------------+ | ||
| Average Memory | 117.5 MiB | 111.0 MiB | 114.2 MiB | 3.2 MiB | | ||
+------------------------+---------------------+---------------------+-----------+----------------------+ | ||
| Average CPU (percent) | 0.07325581395348836 | 0.09432989690721647 | 0.1 | 0.010537041476864052 | | ||
+------------------------+---------------------+---------------------+-----------+----------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this table be generated dynamically seems like it will make it unreadable in the terminal when summarizing more than a few runs. Have you tried testing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Description of tests:
aws s3 cp
and summarize the results in the new detailed JSON format:Output:
And similarly for the table output format:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.