-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhook): make sure webhook urls are valid #133
Conversation
MES-125 Add validation for webhook urls
We should send 400 errors if urls for webhooks aren't valid https urls. |
It looks like there is a problem with Jest and importing other packages from yarn workspaces.
|
Building the repo first seems to solve the problem. I think rewiring might also solve it. You can see how the rewiring works when working with ts-node in the rewire.ts. Ideally we would need to require that file before every test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to send a 400 with a message back to the user otherwise great work!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds a check to make sure that the synced webhook URLs are valid URIs and are reachable using an option request.
Closes MES-125