Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTO-687 [MPPI] Fix Seg fault in path follow critics #15

Merged
merged 1 commit into from
Mar 16, 2023
Merged

AUTO-687 [MPPI] Fix Seg fault in path follow critics #15

merged 1 commit into from
Mar 16, 2023

Conversation

doisyg
Copy link

@doisyg doisyg commented Mar 16, 2023

No description provided.

@doisyg doisyg requested review from scheunemann and a team and removed request for a team March 16, 2023 18:21
@doisyg
Copy link
Author

doisyg commented Mar 16, 2023 •
edited
Loading

Approved upstream ros-navigation#3484 following discussion here: ros-navigation#3480

It makes sense to not use the critic at all if the path is empty

scheunemann
scheunemann approved these changes Mar 16, 2023
View reviewed changes
Copy link

@scheunemann scheunemann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in because it reflects upstream anyway, but will check again later.

@scheunemann scheunemann merged commit 0a5b6af into bau Mar 16, 2023
@scheunemann scheunemann deleted the AUTO-687_fix_path_follow_critics branch March 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheunemann scheunemann scheunemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doisyg @scheunemann