Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport nav2 vel smoother timeout fix #18

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Backport nav2 vel smoother timeout fix #18

merged 5 commits into from
Apr 11, 2023

Conversation

doisyg
Copy link

@doisyg doisyg commented Mar 30, 2023 •
edited
Loading

@BriceRenaudeau
[Velocity smoother] Set zeros command if timeout (ros-navigation#3512)
9b90ae7 
* Set zeros command if timeout

* Fix lint

* Fix gtest 

increase time to allow deceleration

* Always update last_cmd_

* Revert test modif

* remove test logs

* Fix paste error

* Update velocity_smoother.cpp

* Update velocity_smoother.cpp
scheunemann
scheunemann approved these changes Apr 11, 2023
View reviewed changes
Copy link

@scheunemann scheunemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport tested remotely today after smoother fixes. Thank you for taking care and adding it. Looking all good! 👍

@doisyg doisyg merged commit e3712d9 into bau Apr 11, 2023
@doisyg doisyg deleted the backport_nav_smoother_timeout branch April 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheunemann scheunemann scheunemann approved these changes

@jayyoung jayyoung Awaiting requested review from jayyoung

@kaichie kaichie Awaiting requested review from kaichie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doisyg @scheunemann @BriceRenaudeau