Backport collision monitor "limit" model #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add LIMIT polygon type * fix unit tests * Fix MIN_POINT doesn't exist * Fix Action type enum * FIX velocity used * FIX unit test point distance increase point distance to not be in limit field * Update collision_monitor_node_test.cpp * fix status name not updated * [MOD] only single linear limit * Apply review comments * Update nav2_collision_monitor/include/nav2_collision_monitor/types.hpp --------- Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
kaichie
requested review from
a team,
jayyoung,
richardw347,
scheunemann and
doisyg
and removed request for
a team
doisyg
approved these changes
May 30, 2023
scheunemann
reviewed
May 30, 2023
There was a problem hiding this comment.
Hi @kaichie looks good to me. From the looks it shouldn't change anything what is currently implemented with us. However, did you run this on a robot or simulation?
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ros-planning#3519 feature only.