-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The auth_basic() decorator doesn't use functools.wraps(). #586
Comments
alicegoldfuss
added a commit
to alicegoldfuss/bottle
that referenced
this issue
Feb 12, 2014
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementation is:
It doesn't use functools.wraps() on the nested wrapper function, which will stuff up name introspection for any functions which the decorator is applied to.
We have seen this affecting data reported by customers applications into New Relic. We are going to change our instrumentation to fix up the bottle code if we see it is wrong, but you should look at fixing it all the same.
The text was updated successfully, but these errors were encountered: