Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some redundant from FileCheckerThread.run() #1317

Merged
merged 1 commit into from
Sep 7, 2024
Merged

remove some redundant from FileCheckerThread.run() #1317

merged 1 commit into from
Sep 7, 2024

Conversation

SergBobrovsky
Copy link
Contributor

third arg of getattr is default value

@SergBobrovsky
remove some redundant from FileCheckerThread.run()
9d68813 
third arg of `getattr` is default value
oz123
oz123 reviewed Jan 9, 2021
View reviewed changes
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@defnull defnull merged commit 0568460 into bottlepy:master Sep 7, 2024
@defnull
Copy link
Member

defnull commented Sep 14, 2024

Turns out that or '' is needed if __file__ is None, which should never happen but does happen. See #1455 and #1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oz123 oz123 oz123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergBobrovsky @defnull @oz123