Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tough to v0.18 #136

Merged

Conversation

sumukhballal
Copy link
Contributor

@sumukhballal sumukhballal commented Sep 10, 2024

Description of changes:

Updated tough to v0.18.

Testing done:

  • built core-kit for aarch64 and x86_64
  • tested running an instance using x86_64 aws-ecs-1.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@sumukhballal sumukhballal marked this pull request as ready for review September 10, 2024 05:57
@sumukhballal sumukhballal mentioned this pull request Sep 10, 2024
7 tasks
@bcressey
Copy link
Contributor

Can you do a minimal update of just the tough crate?

If I update Cargo.toml to use "0.18" and run cargo check, then I only see updates to two crates - tough and typed-path.

I'm fine with doing a larger set of dependency updates but I'd like to decouple that from this change.

@sumukhballal
Copy link
Contributor Author

Addressed Ben's comment.

@sumukhballal sumukhballal merged commit edc6a35 into bottlerocket-os:develop Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants