Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-twoliter: validate binary checksum on install #147

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Sep 13, 2024

Description of changes:
This performs checksum validation of the downloaded twoliter binary prior to unpacking the tarball.

Testing done:

  • Ran make build and noted that the checksum validated and the installation succeeded
  • Modified the checksum to be incorrect and noted that installation failed (for both architectures)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbgbt cbgbt merged commit 46800c6 into bottlerocket-os:develop Sep 13, 2024
2 checks passed
@cbgbt cbgbt deleted the tl-checksum branch September 13, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants