add: nvidia-cdi-hook to nvidia-container-toolkit #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # N/A
Description of changes:
Downstream users want to use the base
nvidia-container-toolkit
package with CDI. For full CDI support, thenvidia-container-toolkit
package should include thenvidia-cdi-hook
. The hooknvidia-cdi-hook
is the CLI tool that is expected to be called by the container runtime, when specified by the CDI file.For more information about how this hook is packaged by NVIDIA, see the official RPM 1.
For how the CDI hook interacts with the container runtime, see the CDI hook documentation 2.
Testing done:
Before this change, running
nvidia-ctk cdi generate
includes the following log message:Running the same command with this change. The output spec contains references to
nvidia-cdi-hook
and the binary is found on the host:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.