Change Go version for k8s 1.23-1.29 #155
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Sep 19, 2024
Go 1.23 leaks file descriptors if os/exec fails.
bcressey
approved these changes
Sep 19, 2024
arnaldo2792
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.23 leaks file descriptors if os/exec fails.
Issue number:
Closes issue bottlerocket-os/bottlerocket#4201 once consumed.
Description of changes:
Add GO_MAJOR=1.22 for kubernetes packages 1.23 through 1.29. kubernetes 1.30 already had GO_MAJOR=1.22, and kubernetes 1.31 will require 1.23.
Testing done:
Built nodegroups, added to cluster with the Calico configuration that rapidly reproduces the failure.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.