ecs-gpu-init: fix unit dependencies on GPU drivers #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GPU driver functionality has split into two units, one for the proprietary driver and one for the open one. Depending on the version of the driver, one or both units might be present. Update the dependencies to reflect this. Also drop the "Requires", as the "After" ordering should be sufficient, and "Requires" will cause a failure if the unit is not installed. Signed-off-by: Ben Cressey <bcressey@amazon.com>
koooosh
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
The GPU driver functionality has split into two units, one for the proprietary driver and one for the open one. Depending on the version of the driver, one or both units might be present.
Update the dependencies to reflect this. Also drop the "Requires", as the "After" ordering should be sufficient, and "Requires" will cause a failure if the unit is not installed.
Testing done:
Tested
aws-ecs-1-nvidiaandaws-ecs-2-nvidia. Both came up successfully.Ordering on
aws-ecs-1-nvidia:Ordering on
aws-ecs-2-nvidia:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.