host-ctr: support FIPS ECR service endpoints #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
commented
Oct 17, 2024
ginglis13
commented
Oct 17, 2024
ginglis13
force-pushed
the
aws-config-fips-endpoint
branch
from
b5abd25 to
7c8749f
Compare
|
^ specify |
ginglis13
force-pushed
the
aws-config-fips-endpoint
branch
2 times, most recently
from
ed4795e to
8ede63a
Compare
ginglis13
changed the title
use_fips_endpoint in FIPS enabled variants, support -fips ECR service endpoint
ginglis13
force-pushed
the
aws-config-fips-endpoint
branch
from
8ede63a to
282a181
Compare
|
^ recent force pushes trim this PR's scope down to just FIPS ECR support in |
ginglis13
force-pushed
the
aws-config-fips-endpoint
branch
2 times, most recently
from
bd131b9 to
67407ab
Compare
|
^ latest force pushes rebase, renamed variable |
arnaldo2792
reviewed
Oct 22, 2024
Support FIPS ECR endpoints for regions which provide such endpoints. signed-off-by: Gavin Inglis <giinglis@amazon.com>
Extend the ecr-prefix helper to automatically set ECR registry endpoint to its FIPS equivalent if both in a FIPS supported region and running on a FIPS enabled variant. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13
force-pushed
the
aws-config-fips-endpoint
branch
from
67407ab to
70a95da
Compare
|
^ force push addressed feedback, mostly style. |
bcressey
approved these changes
Oct 23, 2024
arnaldo2792
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket#1667
Description of changes:
Add support to host-ctr for FIPS ECR endpoints.
-fipsservice endpoints in host-ctrecr-prefixto set thefipsservice endpoint if the variant is in FIPS mode and the region is FIPS supportedTesting done:
On an
aws-devinstance inus-west-2with FIPS mode enabled:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.