kernel-6.1: add patch for blkio with cgroupsv1 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaldo2792
approved these changes
Oct 29, 2024
bcressey
reviewed
Oct 29, 2024
packages/kernel-6.1/1006-blk-cgroup-Return-ENOMEM-directly-in-blkcg_css_alloc.patch
Outdated
Show resolved
Hide resolved
packages/kernel-6.1/1008-blk-cgroup-don-t-update-io-stat-for-root-cgroup.patch
Outdated
Show resolved
Hide resolved
packages/kernel-6.1/1009-blk-throttle-Fix-io-statistics-for-cgroup-v1.patch
Outdated
Show resolved
Hide resolved
packages/kernel-6.1/1007-blk-cgroup-Optimize-blkcg_rstat_flush.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
|
Updated PR to simplify the patches to focus on the fix with blkio when using cgroupsv1. |
arnaldo2792
reviewed
Oct 30, 2024
Comment on lines
+43
to
+47
| cpu = get_cpu(); | ||
| bis = per_cpu_ptr(bio->bi_blkg->iostat_cpu, cpu); | ||
| flags = u64_stats_update_begin_irqsave(&bis->sync); | ||
| @@ -1984,8 +1987,7 @@ void blk_cgroup_bio_start(struct bio *bio) | ||
| bis->cur.ios[rwd]++; |
There was a problem hiding this comment.
@bcressey were these lines added to make the cherry-pick/port-back happy? I saw they were in what was patch 1008.
There was a problem hiding this comment.
@bcressey were these lines added to make the cherry-pick/port-back happy? I saw they were in what was patch 1008.
The call to cgroup_rstat_updated was what changed, to match the prior code in 6.1, which didn't have the lockless change.
There was also a bit of context that needed to be removed to relocate the guard to the top of the function.
KCSesh
changed the title
KCSesh
changed the title
larvacea
approved these changes
Oct 30, 2024
yeazelm
approved these changes
Oct 30, 2024
arnaldo2792
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
kernel-6.1: add patch for blkio when using cgroupsv1
Testing done:
With commit:
Without commit:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.