Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libstdc++ subpackage to libgcc #253

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
Related: bottlerocket-os/bottlerocket-sdk#215

Description of changes:
Add a libstdc++ subpackage to the libgcc package, so that downstream packages that use C++ can arrange for the library to be installed at runtime without including it in their own files.

Testing done:
Extracted the packaged files and confirmed that the library and symlink were correct:

❯ ls -latr ./*-bottlerocket-linux-gnu/sys-root/usr/lib/
./aarch64-bottlerocket-linux-gnu/sys-root/usr/lib/:
total 2176
lrwxrwxrwx. 1 fedora fedora      19 Nov 11 19:59 libstdc++.so.6 -> libstdc++.so.6.0.29
-rwxr-xr-x. 1 fedora fedora 2216376 Nov 11 19:59 libstdc++.so.6.0.29

./x86_64-bottlerocket-linux-gnu/sys-root/usr/lib/:
total 2212
lrwxrwxrwx. 1 fedora fedora      19 Nov 11 18:53 libstdc++.so.6 -> libstdc++.so.6.0.29
-rwxr-xr-x. 1 fedora fedora 2256504 Nov 11 18:53 libstdc++.so.6.0.29

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Make the libstdc++ library from the SDK available to packages as a
runtime dependency.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
@bcressey bcressey requested review from cbgbt and ytsssun November 11, 2024 20:06
@bcressey bcressey requested a review from larvacea November 11, 2024 21:20
@arnaldo2792 arnaldo2792 merged commit f7e1905 into bottlerocket-os:develop Nov 12, 2024
2 checks passed
@bcressey bcressey deleted the package-libstdcxx branch November 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants