Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: add ecr-credential-provider-1.32 and beta0 source for kubernetes-1.32 #317

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

Sparksssj
Copy link
Contributor

@Sparksssj Sparksssj commented Dec 12, 2024

Issue number:

Part of bottlerocket-os/bottlerocket#4318

Description of changes:

Initial set of changes for kubernetes 1.32 and ecr-credential-provider 1.32 support.

Testing done

Manual checks that both packages build successfully.

$ rpm -qpi build/rpms/kubernetes-1.32/bottlerocket-kubelet-1.32-1.32.0-0.beta0.1734378736.9d11ae11.br1.x86_64.rpm 
Name        : bottlerocket-kubelet-1.32
Version     : 1.32.0
Release     : 0.beta0.1734378736.9d11ae11.br1
Architecture: x86_64
Install Date: (not installed)
Group       : Unspecified
Size        : 1503031
License     : Apache-2.0 AND BSD-3-Clause
Signature   : (none)
Source RPM  : bottlerocket-kubernetes-1.32.0-0.beta0.1734378736.9d11ae11.br1.src.rpm
Build Date  : Mon Dec 16 19:56:41 2024
Build Host  : localhost
URL         : https://github.com/kubernetes/kubernetes
Summary     : Container cluster node agent
Description :
Container cluster node agent.

$ rpm -qpi build/rpms/ecr-credential-provider-1.32/bottlerocket-ecr-credential-provider-1.32-1.32.0-1.1734378736.9d11ae11.br1.x86_64.rpm 
Name        : bottlerocket-ecr-credential-provider-1.32
Version     : 1.32.0
Release     : 1.1734378736.9d11ae11.br1
Architecture: x86_64
Install Date: (not installed)
Group       : Unspecified
Size        : 1005122
License     : Apache-2.0
Signature   : (none)
Source RPM  : bottlerocket-ecr-credential-provider-1.32-1.32.0-1.1734378736.9d11ae11.br1.src.rpm
Build Date  : Mon Dec 16 20:00:44 2024
Build Host  : localhost
URL         : https://github.com/kubernetes/cloud-provider-aws
Summary     : Amazon ECR credential provider
Description :
Amazon ECR credential provider.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@Sparksssj Sparksssj requested review from KCSesh and koooosh December 12, 2024 23:41
@Sparksssj Sparksssj changed the title kubernetes-1.32 and ecr-credential-provider-1.32 update packages: add beta sources for kubernetes-1.32 and ecr-credential-provider-1.32 Dec 12, 2024
@koooosh
Copy link
Contributor

koooosh commented Dec 13, 2024

nit: For the package commits, we technically are not updating the packages; instead we are adding new ones, so I prefer:

  • packages: add kubernetes-1.32
  • packages: add ecr-credential-provider-1.32

@koooosh
Copy link
Contributor

koooosh commented Dec 13, 2024

Even though the ecr-credential-provider-1.32 is technically not a beta source, I'm okay with referring to it as such since the Latest release is still 1.31.4.

@koooosh
Copy link
Contributor

koooosh commented Dec 14, 2024

^ Force push updates GO_VERSION var to a more generic GO_MAJOR

@koooosh koooosh requested a review from yeazelm December 14, 2024 00:01
@koooosh
Copy link
Contributor

koooosh commented Dec 16, 2024

^ Force push updates versioning fields in specs. It removes the Epoch field and updates the Release field to match source.

@koooosh koooosh changed the title packages: add beta sources for kubernetes-1.32 and ecr-credential-provider-1.32 packages: add ecr-credential-provider-1.32 and beta source for kubernetes-1.32 Dec 16, 2024
@koooosh koooosh changed the title packages: add ecr-credential-provider-1.32 and beta source for kubernetes-1.32 packages: add ecr-credential-provider-1.32 and beta0 source for kubernetes-1.32 Dec 16, 2024
@koooosh koooosh requested a review from bcressey December 16, 2024 20:35
@koooosh koooosh merged commit f4dbc27 into bottlerocket-os:develop Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants