try a new approach to reuse cached builds #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
force-pushed
the
cache-resync
branch
2 times, most recently
from
32bd1c2
to
8ab81c4
Compare
|
With the above algorithm and a modified systemd package, the expected rebuilds are: These packages all use the bundled Go modules feature, which may be causing spurious rebuilds: These package rebuilds are a mystery, though at least it's consistent for both x86_64 and aarch64 runners: |
bcressey
force-pushed
the
cache-resync
branch
4 times, most recently
from
c5b1630
to
be4a777
Compare
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
|
Trying a run with a couple
|
|
OK, with the ... just the set of packages we expect to be rebuilt! 🎉 |
|
We're now on a version of Twoliter that supports this hack, so it's getting closer. I realized a shortcoming of the approach here: it only handles file-level modifications that would trigger rebuilds. The environment will be the same for both builds, so we won't do rebuilds for any of the The full set: Of these, the most interesting is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Follow-up on #65
Description of changes:
Try a new strategy to force use of cache:
Testing done:
😬
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.