Re-enable fmt and licenses lints in CI
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Aug 8, 2024
arnaldo2792
approved these changes
Aug 9, 2024
| @@ -55,6 +55,8 @@ deny = [{ name = "structopt" }, { name = "clap", wrappers = ["cargo-readme"] }] | |||
| skip = [ | |||
| # this can be removed once settings sdk is updated to base64 0.22.1 | |||
| { name = "base64", version = "=0.21.7" }, | |||
| # this can be removed once settings sdk is updated to env_logger 0.11 | |||
There was a problem hiding this comment.
Can we have a PR with the update in the Bottlerocket Settings SDK? :D
There was a problem hiding this comment.
Already done! bottlerocket-os/bottlerocket-settings-sdk#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Re-enable
fmtandlicenselints.I'd like to re-enable clippy, but the
dead_codelint is starting to detect our error enum variants if we haven't been careful about conditional compilation or in cases where modules are owned by both aliband abinbut only a subset of the error variants are used in either. This will take some careful changes to do the right way, but we should really have thelicenseslint enabled ASAP.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.