Use workspace dependencies for all dependencies #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Aug 8, 2024
sources/Cargo.toml
Outdated
| shlex = "1" | ||
| signal-hook = "0.3" | ||
| simplelog = "0.12" | ||
| snafu = { version = "0.8", default-features = false } |
There was a problem hiding this comment.
If we specify it this way to enable default features, wouldn't that simplify crate level usage?
Suggested change
| snafu = { version = "0.8", default-features = false } | |
| snafu = "0.8" |
Seems like everything except signpost uses the default features, and signpost should be fine with that instead.
This fixes a few inconsistencies in dependency requirements: * base64 - this is the only semantic change in the commit. Two packages depended on a slightly older version of base64. cargo-deny did not catch this because we have disabled duplicate detection for base64 to accommodate other 3rd party packages. * tempfile - This package does not have any default features. Remove the `default-features = false` flag. * schnauzer - One package had an arbitrarily more-specific version requirement for schnauzer. * snafu - use default features for all packages
|
^ Force push to address @bcressey's suggestion for |
bcressey
approved these changes
Aug 8, 2024
yeazelm
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Most of the heavy lifting here was done by a modified fork of cargo-autoinherit, save for some light formatting. I submitted my patches upstream, but it's not clear yet if they'll take them.
I'm currently working on updating
cargo-denyin the SDK, which now includes a linter that can denyworkspace-dependencyantipatterns.This PR is split into two commits, with my goal being that the
workspacecommit does not change Cargo.lock at all.Testing done:
Cargo.lockhas not changed upon the switch to workspace dependencies.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.