Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to upstream sources via release artifacts rather than generated archives #2831

Open
markusboehme opened this issue Feb 24, 2023 · 2 comments
Assignees
Labels
area/packaging Issues related to the packages bundled in Bottlerocket status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request

Comments

@markusboehme
Copy link
Member

GitHub recently disturbed several projects' build processes by accidentally changing the way archives are generated. The change retained all archive contents, but the structural change led to hash sum checks breaking. More on this can be found in this article on LWN. GitHub responded by promising some advance notice for future changes affecting archive hashes.

Since Bottlerocket refers to third-party packages via https://github.com/${org}/$[repo}/archive/... URLs it would have been similarly affected by this. Consider referring to third-party package sources via static release artifact files instead of archives that are generated on demand.

@markusboehme markusboehme added type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation labels Feb 24, 2023
@markusboehme markusboehme changed the title Refer upstream sources via release artifacts rather than generated archives Refer to upstream sources via release artifacts rather than generated archives Feb 24, 2023
@stmcginnis stmcginnis added status/icebox Things we think would be nice but are not prioritized area/packaging Issues related to the packages bundled in Bottlerocket and removed status/needs-triage Pending triage or re-evaluation labels Feb 27, 2023
@vyaghras vyaghras self-assigned this Mar 13, 2023
@vyaghras
Copy link
Contributor

Following are the packages where we get the tar file from github generated archives:
packages/aws-iam-authenticator/Cargo.toml
packages/aws-signing-helper/Cargo.toml
packages/cni-plugins/Cargo.toml
packages/cni/Cargo.toml
packages/containerd/Cargo.toml
packages/docker-cli/Cargo.toml
packages/docker-engine/Cargo.toml
packages/docker-init/Cargo.toml
packages/docker-proxy/Cargo.toml
packages/ecr-credential-provider/Cargo.toml
packages/ecs-agent/Cargo.toml
packages/hotdog/Cargo.toml
packages/iputils/Cargo.toml
packages/libaudit/Cargo.toml
packages/libnl/Cargo.toml
packages/libnvidia-container/Cargo.toml
packages/log4j2-hotpatch/Cargo.toml
packages/makedumpfile/Cargo.toml
packages/nvidia-container-toolkit/Cargo.toml
packages/nvidia-k8s-device-plugin/Cargo.toml
packages/oci-add-hooks/Cargo.toml
packages/procps/Cargo.toml
packages/systemd/Cargo.toml
packages/wicked/Cargo.toml

@vyaghras
Copy link
Contributor

Will update packages/makedumpfile/Cargo.toml and packages/libnl/Cargo.toml to use static resources once updated version will be available.

ginglis13 added a commit to ginglis13/bottlerocket that referenced this issue Nov 7, 2023
in playing around w/ package and package sources in bottlerocket, I
noticed some 404s. Some were due to the issue outlined in bottlerocket-os#2831
regarding GitHubs switch away from generated archives, with this typo
being an easy outlier to quickly fix.

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
etungsten pushed a commit to etungsten/bottlerocket that referenced this issue Nov 18, 2023
in playing around w/ package and package sources in bottlerocket, I
noticed some 404s. Some were due to the issue outlined in bottlerocket-os#2831
regarding GitHubs switch away from generated archives, with this typo
being an easy outlier to quickly fix.

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Issues related to the packages bundled in Bottlerocket status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants