-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include kmod kit in repos #1287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
samuelkarp
reviewed
Jan 21, 2021
bcressey
approved these changes
Jan 21, 2021
samuelkarp
approved these changes
Jan 21, 2021
e157671
to
ccd6f6a
Compare
^ This push addresses (most of) @bcressey's concerns above. |
ccd6f6a
to
404d499
Compare
^ Quick fix for @bcressey's remaining comment, based on an offline suggestion from him. |
bcressey
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1275.
Description of changes:
This allows for easy, safe retrieval of the kmod kit for a given Bottlerocket release. Updating the
repo
target means we'll automatically upload kits in future releases, starting with v1.0.6.Note: This is based on #1286 and #1285.
Testing done:
Making a repo now includes the kmod kit:
I synced the repo to an S3 bucket and was able to download it with tuftool:
Kit is as expected:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.