Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: run static and non-static Rust builds in parallel #1368

Merged
merged 2 commits into from
Mar 8, 2021
Merged

os: run static and non-static Rust builds in parallel #1368

merged 2 commits into from
Mar 8, 2021

Commits on Mar 5, 2021

  1. os: run static and non-static Rust builds in parallel 

    There's a long tail of crate builds for each that can be mitigated by running
them in parallel, saving a fair amount of time.
    @tjkirch
    tjkirch committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    3cf102d View commit details
    Browse the repository at this point in the history

  2. models build.rs: remove early exit for target toolchain 

    This is a partial revert of 79465cd; the nicer
structure for main() is kept, but the actual early-exit is removed.

We don't actually need the early-exit if it's safe to run this build.rs in
parallel, which it is since 3943a32 introduced
safe link swapping.  The other action it takes, README generation, is skipped
during production builds, and would be obvious if it went wrong during local
builds due to version controlled changes, though it should also be safe there
as long as our READMEs don't balloon and become unsafe to write in parallel.

The reason for removing this is that it effectively worked by chance, because
we were running non-static builds before static builds.  We'd like to run both
sets of builds in parallel to save a significant amount of time.  Static
builds, as run in os.spec, only run build.rs once, with a vendor of
"bottlerocket".  This means build.rs was skipped, and unless non-static builds
won the race and ran their build.rs before static builds got to that crate, the
link wouldn't be created and the build would fail.
    @tjkirch
    tjkirch committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    a7f68d7 View commit details
    Browse the repository at this point in the history