host-ctr: upgrades dependencies for v1.13.0 #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Host containers look 👍🏼 |
stmcginnis
approved these changes
Feb 23, 2023
webern
approved these changes
Feb 24, 2023
jpmcb
force-pushed
the
host-ctr-deps-v1.13.0
branch
from
3df787e to
59e8417
Compare
|
Force pushed to fix grammar in commit message ✍🏼 |
etungsten
reviewed
Feb 24, 2023
sources/host-ctr/go.mod
Outdated
| @@ -3,16 +3,16 @@ module host-ctr | |||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/aws/aws-sdk-go v1.44.176 | |||
| github.com/aws/aws-sdk-go v1.44.208 | |||
| github.com/awslabs/amazon-ecr-containerd-resolver v0.0.0-20221221205310-1903c4ed45d1 | |||
| github.com/containerd/containerd v1.6.15 | |||
There was a problem hiding this comment.
I think we should rebase this PR after #2825 gets merged so we can move to containerd 1.6.18 along with the other dep updates in one go.
There was a problem hiding this comment.
That's a good call - yes; if we're upgrading to containerd 1.6.18, we can wait for that to get in and rebase on that to upgrade those dependencies too
This was referenced Feb 24, 2023
jpmcb
force-pushed
the
host-ctr-deps-v1.13.0
branch
from
59e8417 to
584fee5
Compare
|
Force pushed to:
|
- Upgrades containerd code dependencies to v1.6.19 - Upgrades opencontainers/runtime-spec to one used by containerd v1.6.19 - Upgrades golang.org/x/net and golang.org/x/crypto dependencies (which are not directly used) out of band of them being updated in aws-sdk-go. See the following for more info: aws/aws-sdk-go#4738 Signed-off-by: John McBride <jpmmcb@amazon.com>
jpmcb
force-pushed
the
host-ctr-deps-v1.13.0
branch
from
584fee5 to
7580d3d
Compare
|
Force pushed to upgrade to using the newly cut containerd |
6 tasks
etungsten
approved these changes
Mar 1, 2023
|
Re-built and re-ran tests. Everything's looking good. Will merge today unless someone objects: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #2761
Description of changes:
Testing done:
Testing incoming!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.