ecs-gpu-init: clean up linker flags #3919
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was cherry picked from #3887 since we took the SDK where the change was needed. This avoids building
ecs-gpu-init
with broken symbols which show up with these errors in the system log:From the original commit:
--export-dynamic
is a separate option, independent of-z
, so pass it as its own-Wl
flag.For consistency, pass the same flags to the external linker.
Thanks for @bcressey for having this fix already under review!
Testing done:
Built an aws-ecs-2-nvidia image and it boots correctly and uses the GPU
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.