-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: add metrics settings extension #3963
Merged
sumukhballal
merged 3 commits into
bottlerocket-os:develop
from
sumukhballal:metrics-settings-extension
May 21, 2024
Merged
settings: add metrics settings extension #3963
sumukhballal
merged 3 commits into
bottlerocket-os:develop
from
sumukhballal:metrics-settings-extension
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-berning
reviewed
May 16, 2024
Addressed comments from @sam-berning ! |
sumukhballal
force-pushed
the
metrics-settings-extension
branch
from
May 20, 2024 19:16
1421fc3
to
6f5ba25
Compare
webern
approved these changes
May 20, 2024
webern
reviewed
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run cd sources && cargo check
(it may error, but it's ok) then check in the Cargo.lock changes.
sumukhballal
force-pushed
the
metrics-settings-extension
branch
from
May 20, 2024 20:44
6f5ba25
to
439be0b
Compare
Added changes to address @webern's comments. |
sumukhballal
force-pushed
the
metrics-settings-extension
branch
from
May 20, 2024 21:05
439be0b
to
0a46a57
Compare
Fixed some rustfmt issues. |
sam-berning
approved these changes
May 20, 2024
sumukhballal
force-pushed
the
metrics-settings-extension
branch
from
May 20, 2024 23:58
0a46a57
to
509475a
Compare
sumukhballal
force-pushed
the
metrics-settings-extension
branch
from
May 21, 2024 00:17
509475a
to
10f4df0
Compare
Fixed merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3656
Description of changes:
Creates a metrics settings extension and uses it in every variant's settings model.
Testing done:
Built an aws-ecs-1 variant with the settings-metrics package installed. Called apiclient to verify that the aws settings worked as before. Also called the settings extension to verify that it was behaving as expected.
Setting the URL: Happy case
Setting the service-checks
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.