Deprecate k8s-1.24* variants #4379
Merged
+41
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
reviewed
Jan 28, 2025
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
koooosh
force-pushed
the
deprecate-k8s-1.24
branch
from
c9167a8 to
203c21d
Compare
|
Force push addresses @ginglis13 documentation nits |
ginglis13
approved these changes
Jan 28, 2025
yeazelm
reviewed
Jan 28, 2025
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
koooosh
force-pushed
the
deprecate-k8s-1.24
branch
from
203c21d to
c39e84b
Compare
|
Force push addresses @yeazelm nits on documentation |
yeazelm
approved these changes
Jan 29, 2025
ginglis13
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#4359
Description of changes:
Drop the
aws-k8s-1.24andaws-k8s-1.24-nvidiavariants following the EKS support policy. The variants go EOL in EKS on January 31.Also removes aws-k8s-1.24* settings-defaults and settings-plugins along with updating docs that refer to aws-k8s-1.24*.
Testing done:
cargo makesucceeds,cargo make -e BUILDSYS_VARIANT=aws-k8s-1.24andcargo make -e BUILDSYS_VARIANT=aws-k8s-1.24-nvidiafail.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.