updog: ignore termination signals right before initiating reboot #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
changed the title
tjkirch
reviewed
Mar 25, 2020
To allow updog exit normally (as to indicate successful update operation) after initiating reboot, termination signals are ignored right before `shutdown -r` invocation.
etungsten
force-pushed
the
updog-handle-term
branch
from
963f96d to
2c7d37e
Compare
|
Push above addresses @tjkirch 's comments.
|
sam-aws
approved these changes
Mar 25, 2020
tjkirch
approved these changes
Mar 25, 2020
I tested the new changes with the steps in the PR description and everything still works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #864 and partially addresses bottlerocket-os/bottlerocket-update-operator#28
Description of changes:
Termination signals are ignored right before
shutdown -rinvocation.This change allows
updogto exit normally (with exit code 0, as to indicate a successful updateoperation) after initiating reboot.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.