Go modules #130
Merged
Go modules #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some subtlety in the way GO_MODULES were being found was causing Bottlerocket builds to fail. Rather than find these with yet more bash code in Makefile.toml, we should find these using Rust code when the user is invoking twoliter build variant. Meanwhile, for twoliter make, we expect these to be passed in (which is what the Bottlerocket build does).
webern
requested review from
ecpullen and
bcressey
and removed request for
ecpullen
jpculp
approved these changes
Jan 9, 2024
ecpullen
approved these changes
Jan 9, 2024
webern
added a commit
to webern/twoliter
that referenced
this pull request
Jan 10, 2024
In bottlerocket-os#130 1410d5b we startred requiring GO_MODULES to come from the environment when using twoliter make. This appeared to work because go mod vendor had been cached when testing. But in fact, we were not taking the environment variable at all! So this commit fixes it.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes: N/A
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.