update twoliter and buildsys to put RPMs into per-package sub-directories #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place output RPMs into a subdirectory using the package-name.
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Update the buildsys Dockerfile so that it works with RPM packages being outputted to sub-directories, i.e. build/package-name/ Co-authored-by: Matt Briggs <brigmatt@amazon.com> Co-authored-by: Ben Cressey <bcressey@amazon.com> Signed-off-by: Ben Cressey <bcressey@amazon.com>
Contributor
Author
|
Sorry, closing this because I meant to push a branch to upstream for PR chaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related #185
Related #73
Builds on #198
Description of changes:
In order to construct kits containing the correct RPMs, we need to stop using a flat
build/rpmsstructure. Instead we need to put each RPM into a sub-directory. Then we can use the package-name to find the right RPMs to build repos with the correct RPMs on-the-fly when building packages, kits and variants.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.