-
Notifications
You must be signed in to change notification settings - Fork 40
buildsys build-kit #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildsys build-kit #227
Conversation
jmt-lab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bcressey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor issue.
|
Rebase which appears to have included a conflict resolution error... now fixing. |
|
Fix the rebase mistake and also add |
Add a command to buildsys that can create a kit!
|
Address Ben's comment (don't use the supported_arch function). |
Issue number:
Closes #70
Closes #73
Follows #226
Description of changes:
Add a
build-kitcommand that can create a local kit!Testing done:
Kit test: (note
build-variantfails because the test project does not have a kernel)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.