Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: cli: Quote passed args #2361

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

psydvl
Copy link
Contributor

@psydvl psydvl commented Dec 12, 2022

Description

frontend: cli: run_porgram: Quote passed args

Will allow symbols like & in args

Fix issue with URLs like handler://arg1=bla&arg2=bla, which cause next error

/bin/sh: line 1: arg2=bla: command not found

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@psydvl psydvl marked this pull request as draft December 13, 2022 19:52
@psydvl psydvl changed the title backend: create_desktop_entry: Quote passed links, to allow symbols like & frontend: cli: run_porgram: Quote passed args Dec 13, 2022
Will allow pass symbols like &
@TheEvilSkeleton TheEvilSkeleton changed the title frontend: cli: run_porgram: Quote passed args frontend: cli: Quote passed args Dec 18, 2022
@mirkobrombin mirkobrombin self-requested a review April 15, 2023 06:14
@mirkobrombin
Copy link
Member

Is this still a draft?

@kirides
Copy link

kirides commented Jul 25, 2024

Isn't that an invalid uri scheme?
It should look like the following scheme://host/path

where host usually is an entrypoint for the handler of scheme, like in the case of "bottles" its run, e.g. bottles://run?arg1=v1&arg2=v2 or bottles://run/some?arg1=v1&arg2=v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants