Allow dependencies to be installed in 32 bits bottle #2861
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues the work discussed in #2684.
What changed
Now, we can have the
for
verb on each action in a dependency manifest, like this:This clause takes a list, with
["win32, win64"]
, as valid values. This means that the action will only be executed on a Bottle with the architecture specified. If thefor
verb is not specified, then the action will take place in both architecture.If a dependency is not supported on one architecture, it should be written in the index.yml, like so:
This way, when we open the dependency view, we can show a message that the dependency is not compatible with our Bottle, like this:
Another PR is opened on the dependencies repo, here.
Fixes #2166 and a lot more.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.