Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[#3287]: bottles with a different name and path weren't runnable through bottle picker #3451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LittleAmpton
Copy link

Description

A fix of #3287 which wasn't actually fixed. Here's a quote of my last comment there:

[..] the issue is not about spaces in the bottle's name per se, but about passing the bottle's directory name (which uses hyphens instead of spaces) instead of the bottle's name (i.e. "Windows-games" instead of "Windows games").

I just changed BottleEntry's self.bottle member as I believe this class isn't used anywhere else, nor is the bottles' path actually needed for anything.

Fixes #3287

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Running bottles through flatpak run com.usebottles.bottles//master [executable] and picking a bottle with spaces in its name and/or a bottle whose name doesn't math it's path (e. g. an imported wine prefix)
  • Before this fix the bottles' path would be passed to bottles instead of its name, resulting in an error like Bottle Imported_username not found. After the fix the application is executed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't run bottles with spaces in name through bottle picker
1 participant