-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around a race condition when deleting slide counters #99
Conversation
If SampleMod:trim/2 gets called by a folsom_sample_slide_server after the ETS table the server is trimming has gone away, it will go into a restart loop and eventually bring down the folsom_sample_slide_sup supervisor. This fixes that by catching badarg and stopping the erronous process normally.
Thanks @solvip, this looks like a good patch. Unfortunately I, as maintainer of folsom, no longer have write access to the repo. Sorry, I am not sure when or if this PR will be merged. |
Thanks @joewilliams, too bad. Hopefully someone else will pick this up. |
Maybe @GabrielNicolasAvellaneda @dominicphillips or @sigil66 can give me access again to folsom, bear, folsom_webmachine and folsom_cowboy. |
Hey @joewilliams I don't have access too, but maybe @sigil66 or @codemoran can help. |
@joewilliams Sorry, I can't either. |
Is there any appetite to fork and create a separate organisation to maintain these? I'd be happy to help out. |
I would be happy to help as well |
@puzza007 @solvip okay, I have started https://github.com/folsom-project with fresh copies of the folsom related repos (so we aren't tied in anyway). Please let anyone you know that the repo is changing. @solvip can you please resubmit your PR over there? |
If SampleMod:trim/2 gets called by a folsom_sample_slide_server after the ETS table the server is trimming has gone away, it will go into a restart loop and eventually bring down the folsom_sample_slide_sup supervisor.
This fixes that by catching badarg and stopping the erronous process normally.