Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a race condition when deleting slide counters #99

Closed
wants to merge 1 commit into from
Closed

Work around a race condition when deleting slide counters #99

wants to merge 1 commit into from

Conversation

solvip
Copy link

@solvip solvip commented Oct 27, 2015

If SampleMod:trim/2 gets called by a folsom_sample_slide_server after the ETS table the server is trimming has gone away, it will go into a restart loop and eventually bring down the folsom_sample_slide_sup supervisor.
This fixes that by catching badarg and stopping the erronous process normally.

If SampleMod:trim/2 gets called by a folsom_sample_slide_server after the ETS table the server is trimming has gone away, it will go into a restart loop and eventually bring down the folsom_sample_slide_sup supervisor.
This fixes that by catching badarg and stopping the erronous process normally.
@joewilliams
Copy link
Contributor

Thanks @solvip, this looks like a good patch. Unfortunately I, as maintainer of folsom, no longer have write access to the repo. Sorry, I am not sure when or if this PR will be merged.

@solvip
Copy link
Author

solvip commented Oct 27, 2015

Thanks @joewilliams, too bad. Hopefully someone else will pick this up.

@joewilliams
Copy link
Contributor

Maybe @GabrielNicolasAvellaneda @dominicphillips or @sigil66 can give me access again to folsom, bear, folsom_webmachine and folsom_cowboy.

@GabrielNicolasAvellaneda

Hey @joewilliams I don't have access too, but maybe @sigil66 or @codemoran can help.

@dominicphillips
Copy link

@joewilliams Sorry, I can't either.

@puzza007
Copy link
Contributor

Is there any appetite to fork and create a separate organisation to maintain these? I'd be happy to help out.

@solvip
Copy link
Author

solvip commented Oct 28, 2015

I would be happy to help as well

@joewilliams
Copy link
Contributor

@puzza007 @solvip okay, I have started https://github.com/folsom-project with fresh copies of the folsom related repos (so we aren't tied in anyway). Please let anyone you know that the repo is changing.

@solvip can you please resubmit your PR over there?

@puzza007
Copy link
Contributor

@joewilliams 👍

@solvip
Copy link
Author

solvip commented Oct 28, 2015

👍 folsom-project/folsom#1

@solvip solvip closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants