Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When loading data from a single file keep_yboundaries=False does not work correctly for upper target #113

Closed
johnomotani opened this issue Mar 26, 2020 · 0 comments · Fixed by #180
Closed

When loading data from a single file keep_yboundaries=False does not work correctly for upper target #113

johnomotani opened this issue Mar 26, 2020 · 0 comments · Fixed by #180
Milestone
1.0 - First offic...

Comments

@johnomotani
Copy link
Collaborator

The keep_yboundaries argument to open_boutdataset is implemented in the _trim function and only removes the y-boundary points at the edge of the individual files loaded. If the data has been squashed into a single file that includes a second (upper) target, those points will not be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 - First official release
Development

Successfully merging a pull request may close this issue.

Fix keep_yboundaries=False for squashed, double-null cases boutproject/xBOUT
1 participant
@johnomotani