Fix keep_yboundaries=False for squashed, double-null cases #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the remove_yboundaries() method to remove y-boundaries for any cases with a second divertor.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 75.81% 75.88% +0.07%
==========================================
Files 14 14
Lines 2394 2418 +24
Branches 553 556 +3
==========================================
+ Hits 1815 1835 +20
- Misses 381 385 +4
Partials 198 198
Continue to review full report at Codecov.
|
johnomotani
commented
Mar 19, 2021
Part of code comment related to an implementation detail that was reverted.
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-19 14:29:32 UTC |
johnomotani
commented
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously squashed Datasets (which include boundary cells*) representing double-null cases with a second boundary could only be opened with
keep_yboundaries=True, because when the single file is loaded the boundary cells from the second boundary are always present, and since they are not at the edge like guard cells, they are not easy to remove in the_trim()function. Fix this case by detecting squashed, double-null Datasets, loading them withkeep_yboundaries=True, and then callingds.bout.remove_yboundaries()afterwards.* squashed Datasets that do not include y-boundary cells were fine, because in that case
keep_yboundarieshas nothing to do anyway.Required some small changes so that
remove_yboundaries()could always be called - previously if no geometry was set some metadata andattrs["geometry"]were not set, but are used inremove_yboundaries().Updates to the test-data creation routines to improve the creation of 'squashed' Datasets to test the new feature.
Fixes #113.
Fixes #176.