Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for bout_tdim, bout_xdim, bout_ydim, bout_zdim, so that they always exist #179

Closed
wants to merge 1 commit into from

Conversation

johnomotani
Copy link
Collaborator

Some methods need metadata["bout_ydim"], etc., and it can be useful to have these set even when no geometry is applied.

@codecov-io
Copy link

Codecov Report

Merging #179 (756d73e) into master (f213223) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   75.01%   75.04%   +0.03%     
==========================================
  Files          12       12              
  Lines        2065     2068       +3     
  Branches      475      475              
==========================================
+ Hits         1549     1552       +3     
  Misses        347      347              
  Partials      169      169              
Impacted Files Coverage Δ
xbout/geometries.py 79.45% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f213223...756d73e. Read the comment docs.

@johnomotani
Copy link
Collaborator Author

Closing this as I am not totally sure it is correct without an extra fix to default values in _set_default_toroidal_coordinates() that's present in #180 (which includes this commit already).

@johnomotani johnomotani deleted the always-create-bout-dims branch January 15, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants