Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer packages #179

Merged
merged 7 commits into from
Apr 13, 2019
Merged

Update composer packages #179

merged 7 commits into from
Apr 13, 2019

Conversation

bizurkur
Copy link
Contributor

@bizurkur bizurkur commented Apr 9, 2019

Updated composer packages to newest versions

Testing

  • Tests should pass

@bizurkur
Copy link
Contributor Author

Any objections to merging this? Not sure how coverage dropped 0.1%

I don't know if there should be any rules for "don't merge your own PR" or "must require a review."

I'd like to add phpstan in another PR, but need to touch composer again.

composer.json Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@allejo
Copy link
Member

allejo commented Apr 12, 2019

I personally wasn't sure if this PR was ready for review or was still a WIP. I'd favor having a general policy that at least one other person review/approve a PR but I think it's totally fine to merge your PR once it's gotten feedback from at least one other person. We could also make use of requesting reviews from other maintainers or a team.

@allejo allejo requested a review from a team April 12, 2019 03:48
composer.json Show resolved Hide resolved
@mikey179
Copy link
Member

One thing I noted after my review: the line in CHANGELOG.md mentioning the raise to 7.1 for 2.0.0 should be adjusted.

@mikey179
Copy link
Member

Not sure how coverage dropped 0.1%

It's related to line 323 in vfsStream.php - I don't even know why this line was previously reported as covered.

So I'd say go ahead and merge.

@bizurkur bizurkur merged commit dbb9d0a into bovigo:master Apr 13, 2019
@bizurkur bizurkur deleted the update-composer-packages branch April 15, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants