-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer packages #179
Conversation
Any objections to merging this? Not sure how coverage dropped 0.1% I don't know if there should be any rules for "don't merge your own PR" or "must require a review." I'd like to add phpstan in another PR, but need to touch composer again. |
I personally wasn't sure if this PR was ready for review or was still a WIP. I'd favor having a general policy that at least one other person review/approve a PR but I think it's totally fine to merge your PR once it's gotten feedback from at least one other person. We could also make use of requesting reviews from other maintainers or a team. |
One thing I noted after my review: the line in CHANGELOG.md mentioning the raise to 7.1 for 2.0.0 should be adjusted. |
It's related to line 323 in vfsStream.php - I don't even know why this line was previously reported as covered. So I'd say go ahead and merge. |
Updated composer packages to newest versions
Testing