Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 to our testing lineup #254

Merged
merged 7 commits into from
Aug 2, 2021
Merged

Add PHP 8.1 to our testing lineup #254

merged 7 commits into from
Aug 2, 2021

Conversation

allejo
Copy link
Member

@allejo allejo commented May 10, 2021

Start testing against PHP 8.1 (that's currently in development)

See actions/toolkit#252

@bizurkur bizurkur self-assigned this May 10, 2021
@allejo
Copy link
Member Author

allejo commented Jul 15, 2021

Going to hold off on merging this because of failing 8.1 tests and there's no "allow failure" flag on GH Actions and because phpspec/prophecy does not yet support 8.1-dev

@othercorey
Copy link

there's no "allow failure" flag on GH Actions

If you set continue-on-error for the specific step, it will allow failures.

continue-on-error: ${{ matrix.php-version == '8.1' }}

@allejo allejo force-pushed the test-php-81 branch 2 times, most recently from be4aba5 to f1b958e Compare August 2, 2021 00:00
@allejo allejo merged commit 953553b into master Aug 2, 2021
@allejo allejo deleted the test-php-81 branch August 2, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants