Add context property #270
Merged
Add context property #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streams are expected to have a context property to be populated with the current context. Starting with PHP 8.2, not including this property with emit a deprecation warning.
|
A bit early since PHP 8.2 isn't released but the dynamic property changes where already merged and I ran into this doing some early testing of some different projects. |
|
also PHP documentation of this property https://www.php.net/manual/en/class.streamwrapper.php#streamwrapper.props.context |
allejo
approved these changes
Feb 23, 2022
|
Please create new release with the fix included |
Tagged v1.6.11-alpha.0 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams are expected to have a context property to be populated with the
current context. Starting with PHP 8.2, not including this property with emit a
deprecation warning.