Drop support for php 5 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
drop-php-5-support
branch
from
0c8783d
to
b345f0e
Compare
jaapio
force-pushed
the
drop-php-5-support
branch
3 times, most recently
from
0950cda
to
8dade59
Compare
jaapio
force-pushed
the
drop-php-5-support
branch
from
8dade59
to
a4a4e4c
Compare
allejo
requested changes
Aug 29, 2024
allejo
approved these changes
Aug 29, 2024
|
I will create a new release tonight. Expect it to be there in a few hours |
|
This is going to be a 1.7.0 release because of the breaking changes of dropped version support, right?
…On Aug 29, 2024 at 11:01 AM -0700, Jaap van Otterdijk ***@***.***>, wrote:
I will create a new release tonight. Expect it to be there in a few hours
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dropped support for php versions lower than 7.1 as the new syntax enforces us to do a breaking change. This also allowed me to cleanup the tests a bit.
This should clear the path for php 8.4 support as requested in #289