APIs modularization #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelangel-dev
force-pushed
the
api_modules
branch
from
4ee3e09 to
1a6dba5
Compare
miguelangel-dev
force-pushed
the
api_modules
branch
3 times, most recently
from
570c2bb to
6712caa
Compare
miguelangel-dev
changed the base branch from
nef_playground_app
to
playground_ipad_support
miguelangel-dev
changed the base branch from
playground_ipad_support
to
develop
miguelangel-dev
force-pushed
the
api_modules
branch
4 times, most recently
from
b32ce18 to
e2ec257
Compare
update modulemap minor changes minor changes modulemap support and upgrade SPM to support it
…mport dependencies
minor changes
minor changes minor changes
minor changes
minor changes minor changes
minor changes update public api in nef
minor changes in carthage compiler
miguelangel-dev
force-pushed
the
api_modules
branch
from
db3d1b3 to
52bac77
Compare
truizlop
requested changes
Nov 18, 2019
miguelangel-dev
force-pushed
the
api_modules
branch
from
ebc4226 to
326f31a
Compare
truizlop
requested changes
Nov 19, 2019
miguelangel-dev
force-pushed
the
api_modules
branch
from
113841b to
f03762d
Compare
comments in PR comments in PR
miguelangel-dev
force-pushed
the
api_modules
branch
from
f03762d to
97d62da
Compare
truizlop
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have reviewed the nef-modularization to simplify how users should integrate nef in their projects.
import nefto use nef in their projects.Packagefiles, one of them in/to build theneflibrary; and the second one in/projectto build the binaries.FP(added dependency to Bow) - functional apis to Carbon, Jekyll, MarkdownAPIs
You can find more information in the file
@_exportedmodulemapis only available for C libs, so we can not create a custom layout of how symbols visibility will be through our umbrella-library. Apple has an undocumented kind of import@_exportedthat let us expose symbols of nested libraries. You can read more about it in the following threadOn this way, when the user
import netautomatically is importingNefModels(we expose the symbols of NefModels from nef library, using @_exported)Example of use
I have migrated
nef-pluginto this API version, using the new APIs, you can review it here