Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade graceful-fs to 4.1.3 #53

Merged
merged 1 commit into from
Apr 1, 2016
Merged

upgrade graceful-fs to 4.1.3 #53

merged 1 commit into from
Apr 1, 2016

Conversation

thefourtheye
Copy link
Contributor

fixes: #52

@develar
Copy link

develar commented Feb 17, 2016

+1 Please accept pull request.

@ungoldman
Copy link

npm WARN  graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

This is an underlying dependency for electron-packager, hoping to fix this issue up the chain from here.

electron-packager@5.2.1
├ asar@0.8.3
└─┬ mksnapshot@0.1.0
  └─┬ decompress-zip@0.1.0
    └─ graceful-fs@3.0.8

@zeke
Copy link

zeke commented Mar 21, 2016

This is an underlying dependency for electron-packager, hoping to fix this issue up the chain from here.

Same here. cc @wibblymat and @sindresorhus

@benmann
Copy link
Member

benmann commented Mar 21, 2016

cc @sheerun

@sheerun
Copy link
Contributor

sheerun commented Mar 22, 2016

@thefourtheye @zeke @ungoldman @develar What are the braking changes for graceful-fs 4.x?

@thefourtheye
Copy link
Contributor Author

@sheerun As far as I know there is nothing. Before v4 this was the actual problem with graceful-fs. In 4.0 it was fixed in a backward compatible manner.

@sheerun
Copy link
Contributor

sheerun commented Mar 22, 2016

Well, I don't want to guess.. You want half of the community to do major upgrade of graceful-fs, but there isn't even a changelog available: isaacs/node-graceful-fs#51

@zeke
Copy link

zeke commented Mar 22, 2016

Maybe @isaacs can shed some 💡 on the matter...

@sheerun sheerun merged commit 867e439 into bower:master Apr 1, 2016
@sheerun
Copy link
Contributor

sheerun commented Apr 1, 2016

released as 0.2.1

@zeke
Copy link

zeke commented Apr 1, 2016

Thank you, @sheerun!

@thefourtheye thefourtheye deleted the patch-1 branch April 1, 2016 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bump graceful-fs dependency
6 participants